Passing values from child window to parent window

Today I came across a situation to pass values from child form to parent form . I used following code



window.opener.document.getElementById('txtcity').value = '" + address_city + "';window.opener.document.getElementById('txtstate').value = '" + address_state + "';self.close();");